Allow globals to be injected into the runtime #303
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This has been merged into #496 - I'm quite satisfied it's safe and it lets me write really nice unit tests. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a scary title but I'm pretty sure this is OK!
This PR enables better unit tests in adaptors by letting us inject adaptor functions as global varibles.
This adds an API to the runtime which is NOT intended to be used by the CLI or Runtime Manager.
We should ask really hard questions about the safety of this but I think it looks OK (so long as it's not exposed to third party code).
Anyway this is a prerequisite for the adaptor testing PR OpenFn/adaptors#296
Checklist before requesting a review